Skip to content
This repository has been archived by the owner on Mar 16, 2022. It is now read-only.

Add automated header settings #372

Merged
merged 2 commits into from
Jun 30, 2020
Merged

Add automated header settings #372

merged 2 commits into from
Jun 30, 2020

Conversation

pvlugter
Copy link
Member

I'm not sure what was expected here, but I keep noticing that some files have headers and some don't. The header plugin and settings are enabled and have been applied to some files, but not automatically on compile. This updates and enables automated headers across all projects and configurations.

@ralphlaude
Copy link
Contributor

very nice @pvlugter! It is good for me.
One minor question regarding the copyright text. Shouldn't be Copyright 2019-2020 Lightbend Inc. instead of Copyright 2019 Lightbend Inc.?

@pvlugter
Copy link
Member Author

One minor question regarding the copyright text. Shouldn't be Copyright 2019-2020 Lightbend Inc. instead of Copyright 2019 Lightbend Inc.?

Right, I haven't changed the existing header settings, just added the automate settings. The default for sbt-header is to just use the start year.

There are other ways to do it, although something we want to avoid is automatically applying the current year, where the first PRs of the year all end up with header changes. I think we'd want to apply the header changes separately. The akka build has a more involved setup, which we could also use here for Cloudstate:

https://github.com/akka/akka/blob/master/project/CopyrightHeader.scala

And the related issue for preserving copyright years:

sbt/sbt-header#23

The ideal could be preserving start years and updating the end year on modifications only.

@jroper jroper merged commit 4275270 into cloudstateio:master Jun 30, 2020
@pvlugter pvlugter deleted the headers branch July 2, 2020 22:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants